Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36040 )
Change subject: drivers/usb: Enable EHCI debug during verstage ......................................................................
drivers/usb: Enable EHCI debug during verstage
Change-Id: I14843c1944f2c1e0a26870b576bac549c0cac7f9 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/drivers/usb/Makefile.inc M src/include/console/usb.h 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/36040/1
diff --git a/src/drivers/usb/Makefile.inc b/src/drivers/usb/Makefile.inc index c8d319b..fa995c3 100644 --- a/src/drivers/usb/Makefile.inc +++ b/src/drivers/usb/Makefile.inc @@ -1,4 +1,5 @@ bootblock-$(CONFIG_USBDEBUG) += ehci_debug.c pci_ehci.c console.c gadget.c +verstage-$(CONFIG_USBDEBUG) += ehci_debug.c console.c romstage-$(CONFIG_USBDEBUG) += ehci_debug.c pci_ehci.c console.c gadget.c postcar-$(CONFIG_USBDEBUG) += ehci_debug.c console.c
diff --git a/src/include/console/usb.h b/src/include/console/usb.h index f4f8bd7..33edbf6 100644 --- a/src/include/console/usb.h +++ b/src/include/console/usb.h @@ -31,6 +31,7 @@ ((ENV_BOOTBLOCK && CONFIG(USBDEBUG_IN_PRE_RAM)) || \ (ENV_ROMSTAGE && CONFIG(USBDEBUG_IN_PRE_RAM)) || \ (ENV_POSTCAR && CONFIG(USBDEBUG_IN_PRE_RAM)) || \ + (ENV_VERSTAGE && CONFIG(USBDEBUG_IN_PRE_RAM)) || \ ENV_RAMSTAGE))
#define USB_PIPE_FOR_CONSOLE 0
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36040 )
Change subject: drivers/usb: Enable EHCI debug during verstage ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36040 )
Change subject: drivers/usb: Enable EHCI debug during verstage ......................................................................
Patch Set 1: Code-Review+1
Arthur Heymans has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36040 )
Change subject: drivers/usb: Enable EHCI debug during verstage ......................................................................
drivers/usb: Enable EHCI debug during verstage
Change-Id: I14843c1944f2c1e0a26870b576bac549c0cac7f9 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/36040 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M src/drivers/usb/Makefile.inc M src/include/console/usb.h 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Patrick Rudolph: Looks good to me, approved
diff --git a/src/drivers/usb/Makefile.inc b/src/drivers/usb/Makefile.inc index c8d319b..fa995c3 100644 --- a/src/drivers/usb/Makefile.inc +++ b/src/drivers/usb/Makefile.inc @@ -1,4 +1,5 @@ bootblock-$(CONFIG_USBDEBUG) += ehci_debug.c pci_ehci.c console.c gadget.c +verstage-$(CONFIG_USBDEBUG) += ehci_debug.c console.c romstage-$(CONFIG_USBDEBUG) += ehci_debug.c pci_ehci.c console.c gadget.c postcar-$(CONFIG_USBDEBUG) += ehci_debug.c console.c
diff --git a/src/include/console/usb.h b/src/include/console/usb.h index f4f8bd7..33edbf6 100644 --- a/src/include/console/usb.h +++ b/src/include/console/usb.h @@ -31,6 +31,7 @@ ((ENV_BOOTBLOCK && CONFIG(USBDEBUG_IN_PRE_RAM)) || \ (ENV_ROMSTAGE && CONFIG(USBDEBUG_IN_PRE_RAM)) || \ (ENV_POSTCAR && CONFIG(USBDEBUG_IN_PRE_RAM)) || \ + (ENV_VERSTAGE && CONFIG(USBDEBUG_IN_PRE_RAM)) || \ ENV_RAMSTAGE))
#define USB_PIPE_FOR_CONSOLE 0
-
Arthur Heymans (Code Review) -
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)