Attention is currently required from: SRIDHAR SIRICILLA, Haribalaraman Ramasubramanian, Dinesh Gehlot, Rizwan Qureshi, Reka Norman, Kapil Porwal, Meera Ravindranath.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74005 )
Change subject: soc/intel/cmd/block: Implement an API to get firmware partition details
......................................................................
Patch Set 15:
(1 comment)
File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/74005/comment/4cb8d456_8e63a213
PS15, Line 1243: return false;
wondering if we have to add a print statement to let the user know the ISH partition is not available for this platform ? so the user might know why this API failed ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0582010bbb836bd4734f843a8c74dee49d203fd8
Gerrit-Change-Number: 74005
Gerrit-PatchSet: 15
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: SRIDHAR SIRICILLA
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: SRIDHAR SIRICILLA
Gerrit-Attention: Haribalaraman Ramasubramanian
haribalaraman.r@intel.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Comment-Date: Thu, 06 Apr 2023 05:59:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment