Attention is currently required from: Tarun Tuli, Subrata Banik, Wonkyu Kim, Ravishankar Sarawadi, Paul Menzel, Kapil Porwal, Angel Pons, Nick Vaccaro, Tim Wawrzynczak, Raj Astekar.
Jamie Ryu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66101 )
Change subject: mb/intel/mtlrvp: Enable EC and building ChromeOS
......................................................................
Patch Set 8:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/66101/comment/661ae524_aba51cc5
PS4, Line 9: add
adds
Thanks for the comments. This is updated by patchset#5.
File src/mainboard/intel/mtlrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/66101/comment/5027fd40_37d2650a
PS4, Line 45: default MTL_EC_DETECT
Hmmm, `MTL_CHROME_EC` and `MTL_INTEL_EC` can be chosen manually, as they're part of a choice block.
I tried the override from config file, the config override works as intended and choose the EC config by the config file. Is there anything missing from the current implmentation?
https://review.coreboot.org/c/coreboot/+/66101/comment/1b2dd4dc_5c138b06
PS4, Line 58:
remove one extra line
removed the extra line. thanks.
File src/mainboard/intel/mtlrvp/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/66101/comment/e6fce256_488a36a7
PS4, Line 32: Chrome OS
ChromeOS
Thanks. I removed the comments as it looks the description is redundant.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66101
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I662d7f79050d35e152d97dc5c2118a4af56223bc
Gerrit-Change-Number: 66101
Gerrit-PatchSet: 8
Gerrit-Owner: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Raj Astekar
raj.astekar@intel.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Raj Astekar
raj.astekar@intel.com
Gerrit-Comment-Date: Mon, 03 Oct 2022 18:29:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Wonkyu Kim
wonkyu.kim@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment