Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, John Zhao. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56024 )
Change subject: drivers/usb/acpi: Create function to get PLD information ......................................................................
Patch Set 5:
(2 comments)
File src/drivers/usb/acpi/usb_acpi.c:
https://review.coreboot.org/c/coreboot/+/56024/comment/ad66fefb_954e7cfb PS4, Line 129: static struct acpi_pld pld;
If `usb_acpi_get_pld()` gets called for multiple ports back to back, then the information will get o […]
True Furquan...Let me remove static since anyone calling this function is passing usb_device reference anyway, so we should get information everytime from usb_device.
https://review.coreboot.org/c/coreboot/+/56024/comment/0442281e_6ec5d304 PS4, Line 135: if (config->use_custom_pld) { : /* Use board defined PLD */ : memcpy(&pld, &config->custom_pld, sizeof(pld)); : } else { : /* Fill PLD strucutre based on port type */ : acpi_pld_fill_usb(&pld, config->type, &config->group); : }
nit: I don't think the braces or comments are necessary
Done