Attention is currently required from: Martin Roth.
Hello Martin Roth,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/blobs/+/67352
to review the following change.
Change subject: soc/mediatek: Update capitalization of coreboot ......................................................................
soc/mediatek: Update capitalization of coreboot
coreboot was spelled with a capital C in these files. We don't run the linters on these files, but since they're part of a coreboot-owned repo, let's fix them.
Signed-off-by: Martin Roth martin.roth@amd.corp-partner.google.com Change-Id: Icb1d6ee12057d552938496d198a17b6c8bfd93e8 --- M soc/mediatek/mt8183/README.md M soc/mediatek/mt8186/README.md M soc/mediatek/mt8195/README.md 3 files changed, 25 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/blobs refs/changes/52/67352/1
diff --git a/soc/mediatek/mt8183/README.md b/soc/mediatek/mt8183/README.md index f217387..7233a07 100644 --- a/soc/mediatek/mt8183/README.md +++ b/soc/mediatek/mt8183/README.md @@ -11,13 +11,13 @@
## Who uses it
-Coreboot loads `dram.elf` at the first time bootup if no DRAM parameters have +coreboot loads `dram.elf` at the first time bootup if no DRAM parameters have been cached.
## How to load `dram.elf`
-Coreboot locates `dram.elf` file, and locates the entry point `_start`, +coreboot locates `dram.elf` file, and locates the entry point `_start`, then it passes DRAM struct `param`, and calls `_start(¶m)` to execute `dram.elf` flow.
diff --git a/soc/mediatek/mt8186/README.md b/soc/mediatek/mt8186/README.md index eb7a848..e5e497a 100644 --- a/soc/mediatek/mt8186/README.md +++ b/soc/mediatek/mt8186/README.md @@ -29,7 +29,7 @@ SSPM firmware is loaded into SSPM SRAM at system initialization.
## Who uses it -Coreboot will load sspm.bin to SSPM SRAM at ramstage. +coreboot will load sspm.bin to SSPM SRAM at ramstage.
## How to load `sspm.bin` Use CBFS to load `sspm.bin`. @@ -49,11 +49,11 @@ bootups.
## Who uses it -Coreboot loads `dram.elf` during the first bootup if no valid DRAM parameters +coreboot loads `dram.elf` during the first bootup if no valid DRAM parameters are found on NOR/NAND or eMMC.
## How to load `dram.elf` -Coreboot locates `dram.elf` file, locates the entry point `_start`, +coreboot locates `dram.elf` file, locates the entry point `_start`, passes a `dramc_param` struct argument `dparam` to it, and calls `_start(&dparam)` to execute `dram.elf`.
@@ -130,7 +130,7 @@
## The output of `dram.elf` `dram.elf` configures suitable dramc settings and returns the DRAM parameters. -Then, Coreboot saves the parameters on the specified firmware flash section: +Then, coreboot saves the parameters on the specified firmware flash section: `"RW_MRC_CACHE"`.
## Return values diff --git a/soc/mediatek/mt8195/README.md b/soc/mediatek/mt8195/README.md index 872764b..f7fba10 100644 --- a/soc/mediatek/mt8195/README.md +++ b/soc/mediatek/mt8195/README.md @@ -12,7 +12,7 @@ MCUPM firmware (`mcupm.bin`) is loaded into MCUPM SRAM at system initialization.
## Who uses it -Coreboot will load MCUPM at ramstage. It will copy mcupm.bin to MCUPM SRAM. +coreboot will load MCUPM at ramstage. It will copy mcupm.bin to MCUPM SRAM.
## How to load `mcupm.bin` Use CBFS to load `mcupm.bin`, then set normal boot flag and release software reset pin of MCUPM. @@ -32,7 +32,7 @@ SSPM firmware is loaded into SSPM SRAM at system initialization.
## Who uses it -Coreboot will load sspm.bin to SSPM SRAM at ramstage. +coreboot will load sspm.bin to SSPM SRAM at ramstage.
## How to load `sspm.bin` Use CBFS to load `sspm.bin`. @@ -69,11 +69,11 @@ bootups.
## Who uses it -Coreboot loads `dram.elf` during the first bootup if no valid DRAM parameters +coreboot loads `dram.elf` during the first bootup if no valid DRAM parameters are found on NOR/NAND or eMMC.
## How to load `dram.elf` -Coreboot locates `dram.elf` file, locates the entry point `_start`, +coreboot locates `dram.elf` file, locates the entry point `_start`, passes a `dramc_param` struct argument `dparam` to it, and calls `_start(&dparam)` to execute `dram.elf`.
@@ -138,7 +138,7 @@
## The output of `dram.elf` `dram.elf` configures suitable dramc settings and returns the DRAM parameters. -Then, Coreboot saves the parameters on the specified firmware flash section: +Then, coreboot saves the parameters on the specified firmware flash section: `"RW_MRC_CACHE"`.
## Return values