Change in coreboot[master]: soc/intel/common/acpi: fix Windows crash on S0ix-enabled boards
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47138 )
Change subject: soc/intel/common/acpi: fix Windows crash on S0ix-enabled boards ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47138/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47138/1//COMMIT_MSG@9 PS1, Line 9: Windows
I will test more and add the tested versions
Done
https://review.coreboot.org/c/coreboot/+/47138/1//COMMIT_MSG@22 PS1, Line 22: Windows
It’d be great if you specified the version, you tested with.
Done
https://review.coreboot.org/c/coreboot/+/47138/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47138/3//COMMIT_MSG@7 PS3, Line 7: fix Rather `prevent` because it's not broken atm.?
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l... File src/soc/intel/common/acpi/lpit.asl:
https://review.coreboot.org/c/coreboot/+/47138/1/src/soc/intel/common/acpi/l... PS1, Line 26: debugging
Also see comment from Tim at line 38 here: https://review.coreboot. […]
That doesn't explain why you want to say that here in a comment. The truth would be something along "[...] device constraints for low power states (may be used for debugging [in] Linux)." IMO, too much imple- mentation specific information. So why not leave it to what the spec intended?
-
Nico Huber (Code Review)