Attention is currently required from: Angel Pons, Martin L Roth, Maximilian Brune, Paul Menzel, Subrata Banik, Tim Wawrzynczak.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66545?usp=email )
Change subject: mb/intel/adlrvp: Add ADL-S DDR5 UDIMM 1DPC
......................................................................
Patch Set 23:
(2 comments)
File src/mainboard/intel/adlrvp/variants/adlrvp_s_ddr5_udimm_1dpc/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/66545/comment/7c8297c6_6799e5e4 :
PS23, Line 3: device domain 0 on
Use tabs between the device name and the on keyword.
https://review.coreboot.org/c/coreboot/+/66545/comment/e92748d1_9f35085f :
PS23, Line 23: device ref pcie5_1 off end
Remove?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66545?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic1f62d6dd0b00d26f8c8a71b624ba5fba4c63774
Gerrit-Change-Number: 66545
Gerrit-PatchSet: 23
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alexander Goncharov
chat@joursoir.net
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 15 Nov 2023 14:14:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment