Attention is currently required from: Paul Menzel, Poornima Tom, Shelley Chen, Vamshi Krishna Gopal.
Terry Cheong has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81654?usp=email )
Change subject: mb/google/brox: Update verb table to fix headset detection
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/81654/comment/3b2946b2_fbfa3f83 :
PS1, Line 16: under runtime suspend
reframed.
Runtime suspend here is referring to audio DSP. In legacy hda driver it is mentioned as a parameter as `power_save`. We may actually state this clearly.
Commit Message:
https://review.coreboot.org/c/coreboot/+/81654/comment/16a23cb5_e2d450b3 :
PS2, Line 4: poornima
This is still left unmodified.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81654?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I71b7d59b3ab5310a0b6cdb31fb5033f94263d151
Gerrit-Change-Number: 81654
Gerrit-PatchSet: 2
Gerrit-Owner: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Terry Cheong
htcheong@google.com
Gerrit-Reviewer: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.com
Gerrit-Comment-Date: Wed, 03 Apr 2024 15:01:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Poornima Tom
poornima.tom@intel.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment