Attention is currently required from: Raul Rangel, Martin Roth, Mathew King, EricR Lai, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50450 )
Change subject: mb/google/guybrush: Second pass GPIO configuration
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/google/guybrush/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/50450/comment/43111d4e_40be07cb
PS1, Line 19: PAD_WAKE(GPIO_4, PULL_NONE, EDGE_HIGH, S0i3),
We might need a debounce configuration too.
https://review.coreboot.org/c/coreboot/+/50450/comment/90c2d9ff_72040a17
PS1, Line 22: /* EN_PP3300_WLAN */
: PAD_GPO(GPIO_6, LOW),
: /* EN_PP3300_TCHPAD */
: PAD_GPO(GPIO_7, LOW),
Are we planning to enable these standard components in a subsequent CL or are these enable signals active low?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50450
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fdc4d7369353f88cf05e2e1ec08898d4605e602
Gerrit-Change-Number: 50450
Gerrit-PatchSet: 2
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 11 Feb 2021 19:10:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment