Attention is currently required from: Shelley Chen, Rex-BC Chen, Angel Pons, Yu-Ping Wu, Jianjun Wang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62359 )
Change subject: soc/mediatek: PCIe: Assert PERST# at bootblock stage
......................................................................
Patch Set 18:
(3 comments)
Patchset:
PS18:
Reading the commit message, and then the diff, I am a little confused. Maybe state somewhere, that the preinit only does the assert?
File src/mainboard/google/cherry/bootblock.c:
https://review.coreboot.org/c/coreboot/+/62359/comment/73c1dd36_27eaa355
PS18, Line 48: mtk_pcie_pre_init();
So, this needs to be done for each mainboard, and cannot be done in SOC code?
File src/soc/mediatek/mt8195/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/62359/comment/4c930cf4_98da4303
PS18, Line 11: bootblock-$(CONFIG_PCI) += pcie.c
This could be a separate commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62359
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id5b9369e6f8599f93415588ea585c952a41c5e7d
Gerrit-Change-Number: 62359
Gerrit-PatchSet: 18
Gerrit-Owner: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Jianjun Wang
jianjun.wang@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Sat, 19 Mar 2022 09:05:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment