Tomasz Figa has posted comments on this change. ( https://review.coreboot.org/27433 )
Change subject: mainboard/google/nocturne: Update GPIO_FCAM_PWR_EN ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants/... File src/mainboard/google/poppy/variants/nocturne/gpio.c:
https://review.coreboot.org/#/c/27433/2/src/mainboard/google/poppy/variants/... PS2, Line 181: PAD_CFG_NC(GPP_D8),
I left GPP_D8 configured in gpio. […]
However, just keeping GPP_D8 configured here, without the relevant ACPI code configuring the pin correctly for kernel PM requests, doesn't actually allow camera development.
Given that, we can either 1) just clean it up now or 2) try to make the ACPI code handle both variants.
2) could actually make some sense, if it doesn't introduce any side effects, since it may take quite a while until all the camera people get the new revision.
-
Tomasz Figa (Code Review)