Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30582
Change subject: Kconfig: Remove symbol names for choices ......................................................................
Kconfig: Remove symbol names for choices
These are completely throwing Kconfig off, resulting in duplicate entries.
Change-Id: I401467da686d5011a456b661a10170492a919c81 Signed-off-by: Nico Huber nico.h@gmx.de --- M payloads/external/LinuxBoot/Kconfig M src/mainboard/intel/glkrvp/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/30582/1
diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index 3b8b70c..31b238c 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -219,7 +219,7 @@
endif #LINUXBOOT_BUILD_INITRAMFS
-choice LINUXBOOT_INITRAMFS_COMPRESSION +choice prompt "Initramfs compression format" default LINUXBOOT_INITRAMFS_COMPRESSION_XZ
diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index 9484559..94207ba 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -19,7 +19,7 @@ def_bool n select SYSTEM_TYPE_LAPTOP
-choice GLK_EC +choice prompt "ON BOARD EC" default GLK_CHROME_EC help
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30582 )
Change subject: Kconfig: Remove symbol names for choices ......................................................................
Patch Set 1: Code-Review+1
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30582 )
Change subject: Kconfig: Remove symbol names for choices ......................................................................
Patch Set 1: Code-Review+2
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30582 )
Change subject: Kconfig: Remove symbol names for choices ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30582 )
Change subject: Kconfig: Remove symbol names for choices ......................................................................
Kconfig: Remove symbol names for choices
These are completely throwing Kconfig off, resulting in duplicate entries.
Change-Id: I401467da686d5011a456b661a10170492a919c81 Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/30582 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M payloads/external/LinuxBoot/Kconfig M src/mainboard/intel/glkrvp/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Martin Roth: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve
diff --git a/payloads/external/LinuxBoot/Kconfig b/payloads/external/LinuxBoot/Kconfig index 3b8b70c..31b238c 100644 --- a/payloads/external/LinuxBoot/Kconfig +++ b/payloads/external/LinuxBoot/Kconfig @@ -219,7 +219,7 @@
endif #LINUXBOOT_BUILD_INITRAMFS
-choice LINUXBOOT_INITRAMFS_COMPRESSION +choice prompt "Initramfs compression format" default LINUXBOOT_INITRAMFS_COMPRESSION_XZ
diff --git a/src/mainboard/intel/glkrvp/Kconfig b/src/mainboard/intel/glkrvp/Kconfig index b3ff2fe..920b446 100644 --- a/src/mainboard/intel/glkrvp/Kconfig +++ b/src/mainboard/intel/glkrvp/Kconfig @@ -20,7 +20,7 @@ def_bool n select SYSTEM_TYPE_LAPTOP
-choice GLK_EC +choice prompt "ON BOARD EC" default GLK_CHROME_EC help
-
Martin Roth (Code Review) -
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)
-
Stefan Reinauer (Code Review)