HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37507 )
Change subject: superio/nsc/pc87417: Remove unused <stdint.h> ......................................................................
superio/nsc/pc87417: Remove unused <stdint.h>
Change-Id: Icacf2806702a868a807080e1e2d14b1ee4ed4f90 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/nsc/pc87417/pc87417.h 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/37507/1
diff --git a/src/superio/nsc/pc87417/pc87417.h b/src/superio/nsc/pc87417/pc87417.h index 25401e4..c3fc5ef 100644 --- a/src/superio/nsc/pc87417/pc87417.h +++ b/src/superio/nsc/pc87417/pc87417.h @@ -111,7 +111,6 @@ #define PC87417_XWBCNF 0x16
#include <device/pnp_type.h> -#include <stdint.h>
void pc87417_disable_dev(pnp_devfn_t dev); void pc87417_enable_dev(pnp_devfn_t dev);
Hello Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37507
to look at the new patch set (#2).
Change subject: superio/nsc/pc87417: Remove unused <stdint.h> ......................................................................
superio/nsc/pc87417: Remove unused <stdint.h>
Change-Id: Icacf2806702a868a807080e1e2d14b1ee4ed4f90 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/nsc/pc87417/pc87417.h 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/37507/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37507 )
Change subject: superio/nsc/pc87417: Remove unused <stdint.h> ......................................................................
Patch Set 2: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37507 )
Change subject: superio/nsc/pc87417: Remove unused <stdint.h> ......................................................................
superio/nsc/pc87417: Remove unused <stdint.h>
Change-Id: Icacf2806702a868a807080e1e2d14b1ee4ed4f90 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/37507 Reviewed-by: Felix Held felix-coreboot@felixheld.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/superio/nsc/pc87417/pc87417.h 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/superio/nsc/pc87417/pc87417.h b/src/superio/nsc/pc87417/pc87417.h index 25401e4..c3fc5ef 100644 --- a/src/superio/nsc/pc87417/pc87417.h +++ b/src/superio/nsc/pc87417/pc87417.h @@ -111,7 +111,6 @@ #define PC87417_XWBCNF 0x16
#include <device/pnp_type.h> -#include <stdint.h>
void pc87417_disable_dev(pnp_devfn_t dev); void pc87417_enable_dev(pnp_devfn_t dev);
-
Felix Held (Code Review) -
HAOUAS Elyes (Code Review)