Attention is currently required from: Angel Pons, Patrick Rudolph.
Star Labs has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52796 )
Change subject: src/intel: Add LOCKDIS to mark SPI as writable in SKL
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
0x80 means locked, SMM BIOS write protection not enabled, writes disabled. […]
You can still write to it, that wasn't the problem. It's just the register being wrong.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I712972428dd22373d8655ce72d36c0957ee9a900
Gerrit-Change-Number: 52796
Gerrit-PatchSet: 4
Gerrit-Owner: Star Labs
admin@starlabs.systems
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 10 May 2021 15:47:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Star Labs
admin@starlabs.systems
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Patrick Rudolph
siro@das-labor.org
Gerrit-MessageType: comment