Raul Rangel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37879 )
Change subject: vendorcode/amd/pi/Kconfig: Add promot to pre/post pi files ......................................................................
vendorcode/amd/pi/Kconfig: Add promot to pre/post pi files
This allows the values to be set in a .config
BUG=none TEST=Was able to set the value from a .config and built careena firmware
Change-Id: I757e4b9a0b80ff42c1f49143a44f15550366fd0b Signed-off-by: Raul E Rangel rrangel@chromium.org --- M src/vendorcode/amd/pi/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/37879/1
diff --git a/src/vendorcode/amd/pi/Kconfig b/src/vendorcode/amd/pi/Kconfig index 265a381..9dcdf34 100644 --- a/src/vendorcode/amd/pi/Kconfig +++ b/src/vendorcode/amd/pi/Kconfig @@ -68,7 +68,7 @@ post-memory.
config AGESA_PRE_MEMORY_BINARY_PI_FILE - string + string "Pre memory Binary PI file name" depends on AGESA_SPLIT_MEMORY_FILES default "3rdparty/blobs/pi/amd/00670F00/FT4/AGESA_premem.elf" if SOC_AMD_STONEYRIDGE && USE_AMD_BLOBS help @@ -76,7 +76,7 @@ initialization.
config AGESA_POST_MEMORY_BINARY_PI_FILE - string + string "Post memory Binary PI file name" depends on AGESA_SPLIT_MEMORY_FILES default "3rdparty/blobs/pi/amd/00670F00/FT4/AGESA_postmem.elf" if SOC_AMD_STONEYRIDGE && USE_AMD_BLOBS help
Hello Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37879
to look at the new patch set (#2).
Change subject: vendorcode/amd/pi/Kconfig: Add prompt to pre/post pi files ......................................................................
vendorcode/amd/pi/Kconfig: Add prompt to pre/post pi files
This allows the values to be set in a .config
BUG=none TEST=Was able to set the value from a .config and built careena firmware
Change-Id: I757e4b9a0b80ff42c1f49143a44f15550366fd0b Signed-off-by: Raul E Rangel rrangel@chromium.org --- M src/vendorcode/amd/pi/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/37879/2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37879 )
Change subject: vendorcode/amd/pi/Kconfig: Add prompt to pre/post pi files ......................................................................
Patch Set 2: Code-Review+2
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37879 )
Change subject: vendorcode/amd/pi/Kconfig: Add prompt to pre/post pi files ......................................................................
Patch Set 2: Code-Review+2
Marshall Dawson has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37879 )
Change subject: vendorcode/amd/pi/Kconfig: Add prompt to pre/post pi files ......................................................................
vendorcode/amd/pi/Kconfig: Add prompt to pre/post pi files
This allows the values to be set in a .config
BUG=none TEST=Was able to set the value from a .config and built careena firmware
Change-Id: I757e4b9a0b80ff42c1f49143a44f15550366fd0b Signed-off-by: Raul E Rangel rrangel@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/37879 Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/amd/pi/Kconfig 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Marshall Dawson: Looks good to me, approved Michał Żygowski: Looks good to me, approved
diff --git a/src/vendorcode/amd/pi/Kconfig b/src/vendorcode/amd/pi/Kconfig index 265a381..9dcdf34 100644 --- a/src/vendorcode/amd/pi/Kconfig +++ b/src/vendorcode/amd/pi/Kconfig @@ -68,7 +68,7 @@ post-memory.
config AGESA_PRE_MEMORY_BINARY_PI_FILE - string + string "Pre memory Binary PI file name" depends on AGESA_SPLIT_MEMORY_FILES default "3rdparty/blobs/pi/amd/00670F00/FT4/AGESA_premem.elf" if SOC_AMD_STONEYRIDGE && USE_AMD_BLOBS help @@ -76,7 +76,7 @@ initialization.
config AGESA_POST_MEMORY_BINARY_PI_FILE - string + string "Post memory Binary PI file name" depends on AGESA_SPLIT_MEMORY_FILES default "3rdparty/blobs/pi/amd/00670F00/FT4/AGESA_postmem.elf" if SOC_AMD_STONEYRIDGE && USE_AMD_BLOBS help
-
Marshall Dawson (Code Review) -
Michał Żygowski (Code Review)
-
Raul Rangel (Code Review)