Attention is currently required from: Michał Kopeć, Michał Żygowski, Patrick Rudolph, Paul Menzel, Sergii Dmytruk.
Krystian Hebel has posted comments on this change by Krystian Hebel. ( https://review.coreboot.org/c/coreboot/+/82558?usp=email )
Change subject: mb/qemu-q35/smihandler.c: add support for SMIs on QEMU ......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS2:
The same comments as in https://review.coreboot.org/c/coreboot/+/78088 apply. […]
Moved the implementation to board directory. This also allowed me to fix SMM for qemu-system-i386.
File src/southbridge/intel/common/smihandler.c:
https://review.coreboot.org/c/coreboot/+/82558/comment/b2270850_f5d1e406?usp... : PS2, Line 216: #if !CONFIG(CPU_QEMU_X86) : /* Check for Synchronous IO (bit0 == 1) */ : if (!(state->io_misc_info & (1 << 0))) : continue; : : /* Make sure it was a write (bit4 == 0) */ : if (state->io_misc_info & (1 << 4)) : continue; : : /* Check for APMC IO port */ : if (((state->io_misc_info >> 16) & 0xff) != APM_CNT) : continue; : #endif
Can this be done in C instead of using the preprocessor?
I've moved the code to board directory and modified significantly, so this no longer applies.