Attention is currently required from: Yidi Lin, Yu-Ping Wu.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67357 )
Change subject: mb/google/geralt: Pass reset gpio parameter to BL31
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/geralt/mainboard.c:
https://review.coreboot.org/c/coreboot/+/67357/comment/b632d216_82e0f592
PS4, Line 3: #include <boot/coreboot_tables.h>
do we need this header file here ?
yes, it's for ACTIVE_HIGH.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/67357
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifdfbd6bd82f64b084f6349cb617443053c89a3f1
Gerrit-Change-Number: 67357
Gerrit-PatchSet: 4
Gerrit-Owner: Rex-BC Chen
rex-bc.chen@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Tue, 06 Sep 2022 07:33:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment