Attention is currently required from: Nico Huber, Martin L Roth, Jakub Czapiga, Arthur Heymans, Patrick Rudolph.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62181 )
Change subject: device/dram/ddr: Deduplicate enum spd_dimm_type_ddr{2,3,4}
......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS7:
Thank you.
File src/include/device/dram/ddr4.h:
https://review.coreboot.org/c/coreboot/+/62181/comment/0188e758_153058a9
PS7, Line 29: SPD_DDR4_DIMM_TYPE_EXTENDED = 0x0,
Is this something to worry about?
defined here: src/include/spd.h
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62181
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaffa84704d2a627394b2aae4d35d47d1358a2621
Gerrit-Change-Number: 62181
Gerrit-PatchSet: 7
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Mon, 05 Sep 2022 09:05:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment