[L] Change in coreboot[master]: intelblocks/vtd: Add VT-d block with DMA protection API - coreboot-gerrit

5 Mar 2023


      Attention is currently required from: Michał Żygowski, Angel Pons.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68449 )
Change subject: intelblocks/vtd: Add VT-d block with DMA protection API
......................................................................
Patch Set 9:
(1 comment)
File src/soc/intel/common/block/vtd/vtd.c:
https://review.coreboot.org/c/coreboot/+/68449/comment/464a4393_cd5eb971 
PS9, Line 297: #if ENV_RAMSTAGE && CONFIG(ENABLE_EARLY_DMA_PROTECTION)
Nit: Could this be moved around just the boot_state_init entry or does that cause a compile issue?  If it can, it'd be good to let the compiler check the function, then the linker would optimize it out if it's not used.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/68449
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id7edf982457c1139624e5cd383788eda41d6a948
Gerrit-Change-Number: 68449
Gerrit-PatchSet: 9
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Elias Souza eliascontato@protonmail.com
Gerrit-Reviewer: Michał Kopeć michal.kopec@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Felix Held felix-coreboot@felixheld.de
Gerrit-CC: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-CC: Martin L Roth gaumless@gmail.com
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 05 Mar 2023 16:00:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment