Change in coreboot[master]: mb/google/guybrush: Make GPIO_69 default for SD_AUX_RESET_L - coreboot-gerrit

10 Nov 2021


      Attention is currently required from: Raul Rangel, Rob Barnes, Karthik Ramasubramanian.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59053 )
Change subject: mb/google/guybrush: Make GPIO_69 default for SD_AUX_RESET_L
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/variants/nipperkin/gpio.c:
https://review.coreboot.org/c/coreboot/+/59053/comment/a299f5ca_1dcfae15 
PS2, Line 51: PAD_NC(GPIO_69),
...
Can be removed as well and then bid1_override_pcie_gpio_table can be consolidated with bid2_override […]
this needs to be removed since nipperkin board version 2 uses GPIO69 as SD AUX RESET too, thanks.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/59053
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6546ad9961f6f7146aa3aefc35d39a2eb282a252
Gerrit-Change-Number: 59053
Gerrit-PatchSet: 2
Gerrit-Owner: Rob Barnes robbarnes@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Kevin Chiu kevin.chiu.17802@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Rob Barnes robbarnes@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Comment-Date: Wed, 10 Nov 2021 03:18:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com
Gerrit-MessageType: comment