Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46018 )
Change subject: soc/intel: convert XTAL frequency constant to Kconfig ......................................................................
Patch Set 10:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46018/10/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/Kconfig:
https://review.coreboot.org/c/coreboot/+/46018/10/src/soc/intel/common/block... PS10, Line 102: config SOC_INTEL_COMMON_BLOCK_XTAL_CLOCK_HZ
It reads a bit odd. It's about the CPU block, but you omit `CPU`. So maybe […]
I named it like SOC_INTEL_COMMON_BLOCK_GSPI_CLOCK_MHZ, but yes, XTAL is about the cpu, while gspi isn't. I just found CPU_BCLK_MHZ, so it would make sense to name XTAL like CPU_XTAL_HZ
-
Michael Niewöhner (Code Review)