HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41301 )
Change subject: mb/google/poppy: Remove direct 'include <soc/gpio.h>' ......................................................................
mb/google/poppy: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Change-Id: Icfc610dc67c72f0e71794ad589f266e7a578f94e Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/poppy/bootblock.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/romstage.c M src/mainboard/google/poppy/smihandler.c 4 files changed, 2 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/41301/1
diff --git a/src/mainboard/google/poppy/bootblock.c b/src/mainboard/google/poppy/bootblock.c index efab999..e1f253f 100644 --- a/src/mainboard/google/poppy/bootblock.c +++ b/src/mainboard/google/poppy/bootblock.c @@ -2,7 +2,7 @@
#include <baseboard/variants.h> #include <bootblock_common.h> -#include <soc/gpio.h> +#include <gpio.h>
#include <variant/gpio.h>
diff --git a/src/mainboard/google/poppy/chromeos.c b/src/mainboard/google/poppy/chromeos.c index a51207e..74db169 100644 --- a/src/mainboard/google/poppy/chromeos.c +++ b/src/mainboard/google/poppy/chromeos.c @@ -4,7 +4,6 @@ #include <baseboard/variants.h> #include <boot/coreboot_tables.h> #include <gpio.h> -#include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h>
#include <variant/gpio.h> diff --git a/src/mainboard/google/poppy/romstage.c b/src/mainboard/google/poppy/romstage.c index 0c1fc02..7bcb412 100644 --- a/src/mainboard/google/poppy/romstage.c +++ b/src/mainboard/google/poppy/romstage.c @@ -4,7 +4,7 @@ #include <baseboard/variants.h> #include <cbfs.h> #include <console/console.h> -#include <soc/gpio.h> +#include <gpio.h> #include <soc/romstage.h> #include <string.h> #include <variant/gpio.h> diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c index d54de09..84339e6 100644 --- a/src/mainboard/google/poppy/smihandler.c +++ b/src/mainboard/google/poppy/smihandler.c @@ -5,7 +5,6 @@ #include <ec/google/chromeec/smm.h> #include <elog.h> #include <gpio.h> -#include <soc/gpio.h> #include <intelblocks/smihandler.h>
#include <baseboard/variants.h>
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/41301 )
Change subject: mb/google/poppy: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
see #41324