Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39520 )
Change subject: util/inteltool: add code for dumping GSPI registers ......................................................................
Patch Set 4: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/39520/4/util/inteltool/gspi.c File util/inteltool/gspi.c:
https://review.coreboot.org/c/coreboot/+/39520/4/util/inteltool/gspi.c@150 PS4, Line 150: gspi GSPI
https://review.coreboot.org/c/coreboot/+/39520/4/util/inteltool/gspi.c@155 PS4, Line 155: device disabled. Which device?
https://review.coreboot.org/c/coreboot/+/39520/4/util/inteltool/gspi.c@194 PS4, Line 194: gspi Why the weird casing?
https://review.coreboot.org/c/coreboot/+/39520/4/util/inteltool/gspi.c@204 PS4, Line 204: gspibase Isn't this redundant?
-
Angel Pons (Code Review)