Attention is currently required from: Jarried Lin, Paul Menzel.
Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85034?usp=email )
Change subject: mem_chip_info: Add DDR5/LPDDR5 enums to mem_chip_type
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/commonlib/bsd/include/commonlib/bsd/mem_chip_info.h:
https://review.coreboot.org/c/coreboot/+/85034/comment/5d65b7a7_e10da3c7?usp... :
PS2, Line 15: MEM_CHIP_DDR5 = 0x50,
: MEM_CHIP_LPDDR5 = 0x58,
: MEM_CHIP_LPDDR5X = 0x59
Where are the numbers from?
It just follows the numbering rule here.
https://review.coreboot.org/c/coreboot/+/59193/comment/8b45355f_2bb583ab/
You also joined the review. Don't you ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85034?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic947932bacf9bef53f275685b2616601d0a6823c
Gerrit-Change-Number: 85034
Gerrit-PatchSet: 2
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Crystal Guo
crystal.guo@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 08 Nov 2024 11:10:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org