Yidi Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/86352?usp=email )
(
8 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/mediatek/mt8196: Add validity check for PI_IMG ......................................................................
soc/mediatek/mt8196: Add validity check for PI_IMG
Call check-pi-img.py to perform validity check for the PI_IMG firmware file.
BUG=none TEST=emerge-rauru coreboot TEST=cbfstool coreboot.rom print | grep pi_img BRANCH=rauru
Change-Id: I7b8085c1229c1a7a8cad904e166471ff8bda5cfb Signed-off-by: Yu-Ping Wu yupingso@chromium.org Reviewed-on: https://review.coreboot.org/c/coreboot/+/86352 Reviewed-by: Yidi Lin yidilin@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/mediatek/mt8196/Makefile.mk 1 file changed, 9 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Yidi Lin: Looks good to me, approved
diff --git a/src/soc/mediatek/mt8196/Makefile.mk b/src/soc/mediatek/mt8196/Makefile.mk index 903f57b..9d05ee4 100644 --- a/src/soc/mediatek/mt8196/Makefile.mk +++ b/src/soc/mediatek/mt8196/Makefile.mk @@ -100,6 +100,15 @@ BL31_MAKEARGS += MTKLIB_PATH=$(BL31_LIB) endif
+PI_IMG := $(MT8196_BLOB_DIR)/$(call strip_quotes,$(CONFIG_PI_IMG_FIRMWARE)) + +.PHONY: check_pi_img +check_pi_img: $(PI_IMG) + ./util/mediatek/check-pi-img.py $< + +# Make sure check_pi_img is always run. +$(obj)/coreboot.pre: | check_pi_img + mcu-firmware-files := \ $(CONFIG_DPM_DM_FIRMWARE) \ $(CONFIG_DPM_PM_FIRMWARE) \