Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
Bincai Liu has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85951?usp=email )
Change subject: mb/google/rauru: Add edp driver in mainboard
......................................................................
Patch Set 5:
(4 comments)
File src/mainboard/google/rauru/panel_navi.c:
PS2:
i take a look of previous project, it seems that they also name panel_xxx.c, xxx is project name.
Done
https://review.coreboot.org/c/coreboot/+/85951/comment/efb0f4f3_7fa73483?usp... :
PS2, Line 15: struct panel_description *get_navi_description(void);
it seems that we need create a new header panel.h and then include this panel.h in panel. […]
Done
https://review.coreboot.org/c/coreboot/+/85951/comment/a0d7ee55_9559a69b?usp... :
PS2, Line 24: mdelay(400);
i think this delay is till need
Done
https://review.coreboot.org/c/coreboot/+/85951/comment/947801c5_b9746cab?usp... :
PS2, Line 25: , 1);
: gpio_output(GPIO_BL_PWM_1V8, 1);
do you mean that we can enable backlight in payload?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85951?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iea610c97351beb94a49cc1044701a523b7c85a6e
Gerrit-Change-Number: 85951
Gerrit-PatchSet: 5
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Bincai Liu
bincai.liu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 17 Jan 2025 13:02:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bincai Liu
bincai.liu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com