New patch to review for coreboot: 1b311de google/butterfly: Remove unused cmos.layout options
Alexandru Gagniuc (mr.nuke.me@gmail.com) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/4697
-gerrit
commit 1b311de7194c19c31849de6b2c69f233b0a891c8 Author: Alexandru Gagniuc mr.nuke.me@gmail.com Date: Wed Jan 15 23:28:02 2014 -0600
google/butterfly: Remove unused cmos.layout options
Do not expose options that are unsupported by the board. I tried for a couple of days to see why hyperthreading wasn't working. It's not supported by the CPU. The same applies to the baud_rate option. It makes no sense to expose it to userspace via nvramtool.
Change-Id: I89b91820616d92fb4db20bf77f4b7f48a70353d5 Signed-off-by: Alexandru Gagniuc mr.nuke.me@gmail.com --- src/mainboard/google/butterfly/cmos.layout | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/mainboard/google/butterfly/cmos.layout b/src/mainboard/google/butterfly/cmos.layout index ee5ee25..f0163f1 100644 --- a/src/mainboard/google/butterfly/cmos.layout +++ b/src/mainboard/google/butterfly/cmos.layout @@ -74,12 +74,14 @@ entries
# ----------------------------------------------------------------- # coreboot config options: console -392 3 e 5 baud_rate +# No serial port on this motherboard +#392 3 e 5 baud_rate 395 4 e 6 debug_level #399 1 r 0 unused
# coreboot config options: cpu -400 1 e 2 hyper_threading +# hyper_threading not supported by the Celeron 847 on this board +#400 1 e 2 hyper_threading #401 7 r 0 unused
# coreboot config options: southbridge
-
Alexandru Gagniuc