Change in ...coreboot[master]: skylake: Force to use single channel

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31136

Change subject: skylake: Force to use single channel
......................................................................

skylake: Force to use single channel

Change-Id: I5fea8bdb14922f57d05c1388025a458451035132
Signed-off-by: Sumeet Pawnikar 
---
M src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h
M src/vendorcode/intel/fsp/fsp2_0/denverton_ns/FspmUpd.h
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/31136/1

diff --git a/src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h b/src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h
index fddc168..cfb336b 100644
--- a/src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h
+++ b/src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h
@@ -38,7 +38,7 @@

#define MRC_MAX_RCOMP          3
 #define MRC_MAX_RCOMP_TARGETS  5
-#define MAX_CHANNELS_NUM       2
+#define MAX_CHANNELS_NUM       1
 #define MAX_DIMMS_NUM          2

typedef struct {
diff --git a/src/vendorcode/intel/fsp/fsp2_0/denverton_ns/FspmUpd.h b/src/vendorcode/intel/fsp/fsp2_0/denverton_ns/FspmUpd.h
index 3aa74a0..b4ba865 100644
--- a/src/vendorcode/intel/fsp/fsp2_0/denverton_ns/FspmUpd.h
+++ b/src/vendorcode/intel/fsp/fsp2_0/denverton_ns/FspmUpd.h
@@ -37,7 +37,7 @@

#pragma pack(1)

-#define MAX_CH 2          /* Maximum Number of Memory Channels */
+#define MAX_CH 1          /* Maximum Number of Memory Channels */
 #define MAX_DIMM 2        /* Maximum Number of DIMMs PER Memory Channel */
 #define MAX_SPD_BYTES 512 /* Maximum Number of SPD bytes */

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31136 )

Change subject: skylake: Force to use single channel
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/31136/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/31136/1//COMMIT_MSG@8 
PS1, Line 8: 
Please elaborate why this is needed (motivation).

[David Guckian (Code Review)]

David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31136 )

Change subject: skylake: Force to use single channel
......................................................................

Patch Set 1:

Why change denverton?

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31136 )

Change subject: skylake: Force to use single channel
......................................................................

Patch Set 1:

This makes no sense to apply across the board w/o any explanation what so ever. I can't envision where this would ever be appropriate to change.

Change in ...coreboot[master]: [testonly] skylake: Force to use single channel

[Sumeet R Pawnikar (Code Review)]

Hello Patrick Rudolph, Vanny E, build bot (Jenkins), David Guckian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31136

to look at the new patch set (#2).

Change subject: [testonly] skylake: Force to use single channel
......................................................................

[testonly] skylake: Force to use single channel

Change-Id: I5fea8bdb14922f57d05c1388025a458451035132
Signed-off-by: Sumeet Pawnikar 
---
M src/vendorcode/intel/fsp/fsp1_1/skylake/FspUpdVpd.h
M src/vendorcode/intel/fsp/fsp2_0/denverton_ns/FspmUpd.h
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/31136/2

Change in ...coreboot[master]: [testonly] skylake: Force to use single channel

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31136 )

Change subject: [testonly] skylake: Force to use single channel
......................................................................

Patch Set 2:

This is just an internal testonly patch.

Change in ...coreboot[master]: [testonly] skylake: Force to use single channel

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31136 )

Change subject: [testonly] skylake: Force to use single channel
......................................................................

Patch Set 2:
> Patch Set 2:
>
> This is just an internal testonly patch.

Please mark this patch as WIP or testonly, either using Gerrit's WIP function or in the commit summary.

Change in ...coreboot[master]: [testonly] skylake: Force to use single channel

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31136 )

Change subject: [testonly] skylake: Force to use single channel
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> >
> > This is just an internal testonly patch.
>
> Please mark this patch as WIP or testonly, either using Gerrit's WIP function or in the commit summary.

Please dismiss, I was checking an older version. Apologies for the noise.

[XS] Change in coreboot[master]: [testonly] skylake: Force to use single channel

[Martin L Roth (Code Review)]

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31136?usp=email )

Change subject: [testonly] skylake: Force to use single channel
......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.