Attention is currently required from: YH Lin, Paul Menzel, Angel Pons, Zoey Wu, Zhuohao Lee, Felix Held.
Raihow Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62374 )
Change subject: mb/google/brask/variants/moli: Reduce PSysMax to 11 A
......................................................................
Patch Set 9:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62374/comment/37c71d20_f9d35153
PS2, Line 7: Moli: Review correctness of PSYS energy report
Please look through `git log --oneline` on how to write the prefix.
done
https://review.coreboot.org/c/coreboot/+/62374/comment/06cffbd7_5a79a822
PS2, Line 9: set psys_imax_ma to 11000 mA for moli
Why? Where is that number from?
done
Commit Message:
https://review.coreboot.org/c/coreboot/+/62374/comment/a0a87be2_3469fe85
PS6, Line 7: set psys_imax_ma for moli
Maybe: […]
done
https://review.coreboot.org/c/coreboot/+/62374/comment/7be69f70_e98aaf56
PS6, Line 7: mb/google/brask/variants/moli :
please put the colon `:` next to `moli`, e.g. […]
done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62374
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I61f4813f3527123a590d80b4a6e49d76ebb71c99
Gerrit-Change-Number: 62374
Gerrit-PatchSet: 9
Gerrit-Owner: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.com
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Peter Chi
peter_chi@wistron.corp-partner.google.com
Gerrit-CC: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-CC: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: YH Lin
yueherngl@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Zoey Wu
zoey_wu@wistron.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 03 Mar 2022 05:53:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment