[M] Change in coreboot[master]: drivers/ocp/ewl: Add sending Meta's BMC SEL for memory training error - coreboot-gerrit

2 Nov 2022


      Attention is currently required from: Johnny Lin.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69147 )
Change subject: drivers/ocp/ewl: Add sending Meta's BMC SEL for memory training error
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
File src/drivers/ipmi/ocp/ipmi_ocp.h:
https://review.coreboot.org/c/coreboot/+/69147/comment/3cfbb223_9118db79 
PS2, Line 195: #define INTEL_MEMORY_ERROR	0x21
nit: place this so that the macro numbers are in ascending order?
File src/drivers/ocp/ewl/ewl.c:
https://review.coreboot.org/c/coreboot/+/69147/comment/8278f2bd_4ffac686 
PS2, Line 12:  = 0xff
Unused assignment
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69147
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I664e9d3da7910b47260881c0df64159c8dbe2dca
Gerrit-Change-Number: 69147
Gerrit-PatchSet: 2
Gerrit-Owner: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Shelly Chang Shelly_Chang@wiwynn.com
Gerrit-Attention: Johnny Lin Johnny_Lin@wiwynn.com
Gerrit-Comment-Date: Wed, 02 Nov 2022 14:19:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment