Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35004 )
Change subject: x86: Introduce RESET_VECTOR_IN_RAM option ......................................................................
Patch Set 11: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/35004/10/src/Kconfig File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/35004/10/src/Kconfig@155 PS10, Line 155: config RESET_VECTOR_IN_RAM
It can, if we feel no other arch would soon use it. […]
I think I'd prefer _DRAM, but up to you.
https://review.coreboot.org/c/coreboot/+/35004/11/src/arch/x86/Kconfig File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/35004/11/src/arch/x86/Kconfig@88 PS11, Line 88: soc nit: SoC or SOC
https://review.coreboot.org/c/coreboot/+/35004/10/src/arch/x86/memlayout.ld File src/arch/x86/memlayout.ld:
https://review.coreboot.org/c/coreboot/+/35004/10/src/arch/x86/memlayout.ld@... PS10, Line 20: #if ENV_ROMSTAGE_OR_BEFORE
I would hit #error below for every !ENV_ROMSTAGE_OR_BEFORE ?
Oh, right, okay. Would maybe be nice to indent the inner ones for readability.
-
Julius Werner (Code Review)