Attention is currently required from: Felix Singer, Matt DeVillier, Sean Rhodes.
Alicja Michalska has posted comments on this change by Matt DeVillier. ( https://review.coreboot.org/c/coreboot/+/87504?usp=email )
Change subject: allocator_v4: Re-enable top-down allocation for edk2
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Have you checked all (modern) SoCs?
Last time I tried your fork with top-down alloc, it broke iGPU on TGL-H.
Sure, there are only two boards in coreboot with this specific SoC (sys76/oryp8, erying/tgl) but still...
I can re-test that to make sure though.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87504?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e9b0d02bbf30878aef37a97d6a743a402700fc7
Gerrit-Change-Number: 87504
Gerrit-PatchSet: 1
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alicja Michalska
ahplka19@gmail.com
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Comment-Date: Thu, 01 May 2025 02:09:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No