Attention is currently required from: Ben Kao, Karthik Ramasubramanian. zanxi chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55385 )
Change subject: mb/google/dedede/var/blipper: Update devicetree and gpio setting ......................................................................
Patch Set 2:
(5 comments)
File src/mainboard/google/dedede/variants/blipper/gpio.c:
https://review.coreboot.org/c/coreboot/+/55385/comment/04452833_f8adb995 PS1, Line 9: static const struct pad_config gpio_table[] = {
- if no WWAN, we can set WWAN related pins to NC. […]
1.Done. WWAN related pins that not been closed in baseboard have been all closed. 2.UART2_RTS_N and UART2_CTS_N have been closed in the baseboard. 3.Done. 4.GP_E00 is used by ucam.
https://review.coreboot.org/c/coreboot/+/55385/comment/b667eced_f49ed8e0 PS1, Line 22: /* G7 : SD_SDIO_WP */ : PAD_NC(GPP_G7, NONE),
if GPP_G7 is set to NC, it will have SD card detection issue, please remove it.
Done
File src/mainboard/google/dedede/variants/blipper/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/55385/comment/9d869524_50b4f893 PS1, Line 25: .i2c[1] = { : .speed = I2C_SPEED_FAST, : },
You can remove it if you don't use it anymore.
Done
https://review.coreboot.org/c/coreboot/+/55385/comment/047b8825_f7777801 PS1, Line 31: .i2c[3] = { : .speed = I2C_SPEED_FAST, : },
You can remove it if you don't use it anymore.
Done
https://review.coreboot.org/c/coreboot/+/55385/comment/5f2410db_a75e11d8 PS1, Line 61: register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_D13)"
What's the purpose? It may delay the enabling of the USB camera during system startup, you can remov […]
Done