[S] Change in coreboot[master]: acpi: Add function to print debug string directly from formatted string
Attention is currently required from: Bora Guvendik, Lance Zhao, Hannah Williams, Cliff Huang, Jérémy Compostella, Paul Menzel, Tim Wawrzynczak, Nick Vaccaro.
Jakub Czapiga has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73113 )
Change subject: acpi: Add function to print debug string directly from formatted string ......................................................................
Patch Set 2:
(1 comment)
File src/include/acpi/acpigen.h:
https://review.coreboot.org/c/coreboot/+/73113/comment/5f3a4ae3_faa3162a PS2, Line 508: acpigen_write_debug
will acpigen_write_sprintf_debug() or acpigen_sprintf_write_debug() be better function name? sprintf […]
Right. `Debug` does not support sprintf formatting, we do it n the coreboot side and just paste preformatted string. `acpigen_write_...()` tells us that this function is one from family of functions writing some AML, so I would not put anything in the middle of it. Next there is a group of `acpigen_write_debug...()` functions. So we have to come up with some suffix to this name. I think we can use `acpigen_write_debug_sprintf()` as AML does not have sprintf functionality anyway nor (I think) it will have in near future. You can add appropriate comment to describe purpose of this function.
Oh, and please add `__attribute__((format(printf, 1, 2)))` like it is done in `src/include/console/console.h`
-
Jakub Czapiga (Code Review)