Attention is currently required from: Andrey Pronin, Raul Rangel, Mohan Viswanathan, Jon Murphy, Paul Menzel, Rob Barnes, Yu-Ping Wu, Karthik Ramasubramanian.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61521 )
Change subject: security/vboot/secdata_tpm: Set up space for widevine counter info
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS3:
I have updated the commit message with what Mohan mentioned. Please provide your inputs.
Sorry, I was more hoping for an exact struct layout or something. How many counters are available could just be determined by reading them until you get a BAD_INDEX error. How many counters are in use... can't that just be hardcoded per board, do you really need that to be runtime-variable? Why don't we know how many counters we're planning to use yet?
File src/security/vboot/antirollback.h:
https://review.coreboot.org/c/coreboot/+/61521/comment/ccf39324_d521efa5
PS4, Line 36: #define WIDEVINE_COUNTER_INFO_NV_INDEX 0x3010
Ack
FWIW for coreboot purposes this file is supposed to serve as that global registry. They should all be listed here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61521
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80de9024195452a235cbed73e21410f848c91722
Gerrit-Change-Number: 61521
Gerrit-PatchSet: 4
Gerrit-Owner: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@google.com
Gerrit-Reviewer: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Mohan Viswanathan
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Pronin
apronin@google.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Mohan Viswanathan
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rob Barnes
robbarnes@google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Tue, 01 Feb 2022 23:43:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Mohan Viswanathan
Comment-In-Reply-To: Jon Murphy
jpmurphy@google.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment