Nitheesh Sekar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29970 )
Change subject: qcs405: Add RPM support
......................................................................
Patch Set 33:
(3 comments)
https://review.coreboot.org/c/coreboot/+/29970/25//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/29970/25//COMMIT_MSG@7
PS25, Line 7: Added
Add
Done
https://review.coreboot.org/c/coreboot/+/29970/32/src/soc/qualcomm/qcs405/in...
File src/soc/qualcomm/qcs405/include/soc/symbols.h:
https://review.coreboot.org/c/coreboot/+/29970/32/src/soc/qualcomm/qcs405/in...
PS32, Line 28: extern u8 _rpm[];
DECLARE_REGION(rpm)?
Done
https://review.coreboot.org/c/coreboot/+/29970/32/src/soc/qualcomm/qcs405/in...
PS32, Line 30: #define _rpm_size (_erpm - _rpm)
replace with REGION_SIZE(rpm) at the use sites?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/29970
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I17f491f0a4bd0dce7522b7e80e1bac97ec18b945
Gerrit-Change-Number: 29970
Gerrit-PatchSet: 33
Gerrit-Owner: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nitheesh Sekar
nsekar@codeaurora.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sricharan Ramabadhran
srichara@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 11 Jul 2019 05:27:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment