Change in coreboot[master]: amdfwtool: Print the entry type when dumping the firmwares - coreboot-gerrit

1 Jun 2021


      Attention is currently required from: Marshall Dawson, Zheng Bao.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54900 )
Change subject: amdfwtool: Print the entry type when dumping the firmwares
......................................................................
Patch Set 3:
(2 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/54900/comment/88a1dca9_9e22f3c2 
PS2, Line 653: %x:
...
Maybe %02x or more in order to align of the strings. […]
Done
https://review.coreboot.org/c/coreboot/+/54900/comment/55949c6d_11ff3fbb 
PS2, Line 664: %x
...
Whatever you decide above, repeat here
Done
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/54900
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I07bf10e16a42a2b2ab784ee6ac4a4465b7412da6
Gerrit-Change-Number: 54900
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Tue, 01 Jun 2021 10:03:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-MessageType: comment