Attention is currently required from: Felix Singer, Martin L Roth.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80311?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: docker/doc.coreboot.org: Install pip modules into virtual env ......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
The CI doesn't verify this, so I'm assuming it's been verified manually. […]
Yes, I manually verified that this works. According to the Dockerfile documentation, any variables added using the ENV instruction also gets added to the environment of the container. I added the activation of the venv to /root/.bashrc, though util/docker/Makefile seems to run docker-build-docs as a non-root user. I did originally try putting it into a user folder, but I think I had some issue getting a user created or something.
https://docs.docker.com/reference/dockerfile/#env