Attention is currently required from: Angel Pons, Subrata Banik, Tarun Tuli.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76687?usp=email )
Change subject: [NEEDSTEST]soc/intel/alderlake: Disable PCIe clock gating
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/76687/comment/452b79ff_476f0172 :
PS1, Line 923: #if CONFIG(FSP_TYPE_IOT)
What is this guard for? Does Client FSP not have these UPDs?
It has the same UPDs, but it haven't been updated yet, thus the UPD is still missing.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76687?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I673bbdbadc9afbed6a7bd5ce9f35dc70716d875b
Gerrit-Change-Number: 76687
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 01 Aug 2023 16:16:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment