Srinidhi N Kaushik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48067 )
Change subject: src/soc/intel/tigerlake: Get SPI-DMI destination Id ......................................................................
src/soc/intel/tigerlake: Get SPI-DMI destination Id
Add support to get SPI_DMI destination id. This change implements SOC function that rteruns SPI-DMI Destination id by calling soc_get_spi_dmi_destination_id().
BUG=b:171534504
Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Change-Id: Idf500f1ccf576bbb903bdb5e218263d3f1295ae8 --- M src/soc/intel/tigerlake/spi.c 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/48067/1
diff --git a/src/soc/intel/tigerlake/spi.c b/src/soc/intel/tigerlake/spi.c index 63d9d80..fa63713 100644 --- a/src/soc/intel/tigerlake/spi.c +++ b/src/soc/intel/tigerlake/spi.c @@ -7,7 +7,9 @@ */
#include <intelblocks/spi.h> +#include <intelblocks/fast_spi.h> #include <soc/pci_devs.h> +#include <soc/pcr_ids.h>
int spi_soc_devfn_to_bus(unsigned int devfn) { @@ -23,3 +25,8 @@ } return -1; } + +uint32_t soc_get_spi_dmi_destination_id() +{ + return SPI_DMI_DESTINATION_ID; +}
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48067 )
Change subject: src/soc/intel/tigerlake: Get SPI-DMI destination Id ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48067/1/src/soc/intel/tigerlake/spi... File src/soc/intel/tigerlake/spi.c:
https://review.coreboot.org/c/coreboot/+/48067/1/src/soc/intel/tigerlake/spi... PS1, Line 29: uint32_t soc_get_spi_dmi_destination_id() Bad function definition - uint32_t soc_get_spi_dmi_destination_id() should probably be uint32_t soc_get_spi_dmi_destination_id(void)
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48067
to look at the new patch set (#2).
Change subject: src/soc/intel/tigerlake: Get SPI-DMI destination Id ......................................................................
src/soc/intel/tigerlake: Get SPI-DMI destination Id
Add support to get SPI_DMI destination id. This change implements SOC function that rteruns SPI-DMI Destination id by calling soc_get_spi_dmi_destination_id().
BUG=b:171534504
Signed-off-by: Srinidhi N Kaushik srinidhi.n.kaushik@intel.com Change-Id: Idf500f1ccf576bbb903bdb5e218263d3f1295ae8 --- M src/soc/intel/tigerlake/spi.c 1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/48067/2
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48067 )
Change subject: src/soc/intel/tigerlake: Get SPI-DMI destination Id ......................................................................
Patch Set 2:
This change can be squashed into CB:47989
Stefan Reinauer has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48067?usp=email )
Change subject: src/soc/intel/tigerlake: Get SPI-DMI destination Id ......................................................................
Abandoned