Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32734 )
Change subject: mb/supermicro/x11ssh: Add Supermicro X11SSH-TF
......................................................................
Patch Set 71:
(3 comments)
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
File src/mainboard/supermicro/x11ssh/variants/tf/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
PS68, Line 28: register "SkipExtGfxScan" = "1"
Works without FSP knowing about that device as it only claims 16MiB BAR.
Will the video also be output to Aspeed VGA If I install an external graphics card in the PEG port?
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
PS68, Line 209: device pci 01.0 on end # PCI Slot
unused
Sorry, it seemed to me that PEG0 is used for the NVMe M.2
https://review.coreboot.org/c/coreboot/+/32734/68/src/mainboard/supermicro/x...
PS68, Line 210: device pci 01.1 on
PEGx8 slot, […]
- I think it would be better to use width limit. This allows SFP to do bus training only for the PCIe data lines that are used in the slot/connector.
- In my case, PEG Gen3 only works with SRCCLKREQ/CLKSRC.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32734
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2edaa4a928de3a065e517c0f20e3302b4b702323
Gerrit-Change-Number: 32734
Gerrit-PatchSet: 71
Gerrit-Owner: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Keno Fischer
keno@alumni.harvard.edu
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Name of user not set #1002358
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: T. Hudson
trammell.hudson@gmail.com
Gerrit-Reviewer: Trammell Hudson
hudson@trmm.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Michael Niewöhner
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 19 Aug 2019 20:01:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-MessageType: comment