Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47229 )
Change subject: mb/ocp/deltalake: Configure GPIO for DVT ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47229/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47229/3//COMMIT_MSG@11 PS3, Line 11: Add a config to switch between EVT and DVT.
I would prefer to determine at runtime whether a board is EVT or DVT. […]
Jingle, what's the best way to differentiate between EVT, DVT and PVT? In case of DeltaLake, does CPUID change between DVT and PVT? If it does, CPUID can be used. Otherwise the best way is to use IPMI response from BMC, and default to DVT if there is issue with BMC communication? This would involve boot time differentiation instead of build time.
-
Jonathan Zhang (Code Review)