James has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31003
Change subject: mb/lenovo/x131e: add VBT ......................................................................
mb/lenovo/x131e: add VBT
Change-Id: Ibedb43852dc9b846850e1070b84f708c847b7dbf Signed-off-by: James Ye jye836@gmail.com --- M src/mainboard/lenovo/x131e/Kconfig A src/mainboard/lenovo/x131e/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/31003/1
diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig index e063a38..2a58020 100644 --- a/src/mainboard/lenovo/x131e/Kconfig +++ b/src/mainboard/lenovo/x131e/Kconfig @@ -21,6 +21,7 @@ select MAINBOARD_HAS_LIBGFXINIT select GFX_GMA_INTERNAL_IS_LVDS select SERIRQ_CONTINUOUS_MODE + select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR string diff --git a/src/mainboard/lenovo/x131e/data.vbt b/src/mainboard/lenovo/x131e/data.vbt new file mode 100644 index 0000000..30adeaa --- /dev/null +++ b/src/mainboard/lenovo/x131e/data.vbt Binary files differ
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31003 )
Change subject: mb/lenovo/x131e: add VBT ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/#/c/31003/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31003/1//COMMIT_MSG@8 PS1, Line 8: You could add some information here how you extracted the VBT, e.g. from the BIOS rom? or from a running system?
Also, what did you test? In theory, Linux should be able to bring the display up even if the firmware didn't.
Hello Alexander Couzens, Patrick Rudolph, Arthur Heymans, build bot (Jenkins), Nico Huber, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/31003
to look at the new patch set (#2).
Change subject: mb/lenovo/x131e: add VBT ......................................................................
mb/lenovo/x131e: add VBT
VBT was extracted from VBIOS ROM. Tested with libgfxinit, booting SeaBIOS into Linux.
Change-Id: Ibedb43852dc9b846850e1070b84f708c847b7dbf Signed-off-by: James Ye jye836@gmail.com --- M src/mainboard/lenovo/x131e/Kconfig A src/mainboard/lenovo/x131e/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/31003/2
James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31003 )
Change subject: mb/lenovo/x131e: add VBT ......................................................................
Patch Set 2:
(1 comment)
Done. Not sure what else to test - graphics init worked before, it still works now.
Coreboot says `GMA: Found valid VBT in CBFS`.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31003 )
Change subject: mb/lenovo/x131e: add VBT ......................................................................
Patch Set 2: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31003 )
Change subject: mb/lenovo/x131e: add VBT ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31003/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31003/2//COMMIT_MSG@9 PS2, Line 9: VBT was extracted from VBIOS ROM. From the running system or firmware file?
https://review.coreboot.org/#/c/31003/2//COMMIT_MSG@10 PS2, Line 10: Tested with libgfxinit, booting SeaBIOS into Linux. I guess you used SeaVGABIOS too:
… booting SeaBIOS with SeaVGABIOS into Linux.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31003 )
Change subject: mb/lenovo/x131e: add VBT ......................................................................
Patch Set 2: Code-Review+2
James has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31003 )
Change subject: mb/lenovo/x131e: add VBT ......................................................................
Patch Set 2:
(2 comments)
(2 comments)
https://review.coreboot.org/#/c/31003/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31003/2//COMMIT_MSG@9 PS2, Line 9: VBT was extracted from VBIOS ROM.
From the running system or firmware file?
From firmware, I say "ROM" implies this.
https://review.coreboot.org/#/c/31003/2//COMMIT_MSG@10 PS2, Line 10: Tested with libgfxinit, booting SeaBIOS into Linux.
I guess you used SeaVGABIOS too: […]
Yes, this is the default. I think it's OK as-is.
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31003 )
Change subject: mb/lenovo/x131e: add VBT ......................................................................
mb/lenovo/x131e: add VBT
VBT was extracted from VBIOS ROM. Tested with libgfxinit, booting SeaBIOS into Linux.
Change-Id: Ibedb43852dc9b846850e1070b84f708c847b7dbf Signed-off-by: James Ye jye836@gmail.com Reviewed-on: https://review.coreboot.org/c/31003 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/lenovo/x131e/Kconfig A src/mainboard/lenovo/x131e/data.vbt 2 files changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Nico Huber: Looks good to me, but someone else must approve Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/mainboard/lenovo/x131e/Kconfig b/src/mainboard/lenovo/x131e/Kconfig index e063a38..2a58020 100644 --- a/src/mainboard/lenovo/x131e/Kconfig +++ b/src/mainboard/lenovo/x131e/Kconfig @@ -21,6 +21,7 @@ select MAINBOARD_HAS_LIBGFXINIT select GFX_GMA_INTERNAL_IS_LVDS select SERIRQ_CONTINUOUS_MODE + select INTEL_GMA_HAVE_VBT
config MAINBOARD_DIR string diff --git a/src/mainboard/lenovo/x131e/data.vbt b/src/mainboard/lenovo/x131e/data.vbt new file mode 100644 index 0000000..30adeaa --- /dev/null +++ b/src/mainboard/lenovo/x131e/data.vbt Binary files differ
-
Angel Pons (Code Review) -
James (Code Review)
-
Martin Roth (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Paul Menzel (Code Review)