Change in coreboot[master]: mb/google/dedede: Configure EC <-> AP GPIOs

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Karthik Ramasubramanian (Code Review)

5 Mar 2020 5 Mar '20

8:18 p.m.

Hello Karthikeyan Ramasubramanian,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/39325

to review the following change.

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

mb/google/dedede: Configure EC <-> AP GPIOs

BUG=b:150869661 TEST=Build and boot the mainboard. Trigger apreset from EC console. Trigger reboot from AP console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/39325/1

diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index cfa7d54..f71aea9 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -126,9 +126,9 @@ /* C13 : GPP_C13/UART1_TXD */ PAD_CFG_NF(GPP_C13, NONE, DEEP, NF1), /* C14 : EC_IN_RW_OD */ - PAD_CFG_NF(GPP_C14, NONE, DEEP, NF1), + PAD_CFG_GPI(GPP_C14, NONE, DEEP), /* C15 : EC_AP_MKBP_INT_L */ - PAD_CFG_NF(GPP_C15, NONE, DEEP, NF1), + PAD_CFG_GPI_APIC(GPP_C15, NONE, PLTRST, LEVEL, INVERT), /* C16 : AP_I2C_TRACKPAD_SDA_3V3 */ PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* C17 : AP_I2C_TRACKPAD_SCL_3V3 */ @@ -369,7 +369,7 @@ /* GPD1 : GPP_GPD1/ACPRESENT */ PAD_CFG_NF(GPD1, NONE, DEEP, NF1), /* GPD2 : EC_AP_WAKE_ODL */ - PAD_CFG_NF(GPD2, NONE, DEEP, NF1), + PAD_CFG_GPI(GPD2, NONE, DEEP), /* GPD3 : EC_AP_PWR_BTN_ODL */ PAD_CFG_NF(GPD3, NONE, DEEP, NF1), /* GPD4 : AP_SLP_S3_L */

Attachments:

attachment.htm (text/html — 3.5 KB)

Show replies by date

Karthik Ramasubramanian (Code Review)

5 Mar 5 Mar

9:18 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39325 )

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39325/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39325/1/src/mainboard/google/dedede... PS1, Line 372: PAD_CFG_GPI Checking if this is the right config for Wake interrupt.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 05 Mar 2020 21:18:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

9:32 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39325 )

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39325/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39325/1/src/mainboard/google/dedede... PS1, Line 372: PAD_CFG_GPI

...

Checking if this is the right config for Wake interrupt.

Leave it as NF1 - LAN_WAKE.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 05 Mar 2020 21:32:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

9:58 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak, Aamir Bohra, Karthikeyan Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39325

to look at the new patch set (#2).

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

mb/google/dedede: Configure EC <-> AP GPIOs

BUG=b:150869661 TEST=Build and boot the mainboard. Trigger apreset from EC console. Trigger reboot from AP console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/39325/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

9:59 p.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39325 )

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39325/1/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39325/1/src/mainboard/google/dedede... PS1, Line 372: PAD_CFG_GPI

...

Leave it as NF1 - LAN_WAKE.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 2 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 05 Mar 2020 21:59:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian kramasub@google.com Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

6 Mar 6 Mar

7:42 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak, Aamir Bohra, Karthikeyan Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39325

to look at the new patch set (#3).

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

mb/google/dedede: Configure EC <-> AP GPIOs

BUG=b:150869661 TEST=Build and boot the mainboard. Trigger apreset from EC console. Trigger reboot from AP console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/39325/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 3 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

7:38 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak, Aamir Bohra, Karthikeyan Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39325

to look at the new patch set (#4).

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

mb/google/dedede: Configure EC <-> AP GPIOs

BUG=b:150869661 TEST=Build and boot the mainboard. Trigger apreset from EC console. Trigger reboot from AP console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/39325/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Justin TerAvest (Code Review)

8:29 p.m.

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39325 )

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 06 Mar 2020 20:29:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

7 Mar 7 Mar

2:20 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39325 )

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39325/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39325/4/src/mainboard/google/dedede... PS4, Line 131: GPP_C15 Just a note: This will have to be exposed in EC ACPI tables eventually.

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 4 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sat, 07 Mar 2020 02:20:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Karthik Ramasubramanian (Code Review)

8 Mar 8 Mar

5:09 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak, Aamir Bohra, Karthikeyan Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39325

to look at the new patch set (#5).

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

mb/google/dedede: Configure EC <-> AP GPIOs

BUG=b:150869661 TEST=Build and boot the mainboard. Trigger apreset from EC console. Trigger reboot from AP console.

Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 --- M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h M src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h 3 files changed, 7 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/39325/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 5 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

5:12 a.m.

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak, Aamir Bohra, Karthikeyan Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/39325

to look at the new patch set (#6).

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

mb/google/dedede: Configure EC <-> AP GPIOs

BUG=b:150869661 TEST=Build and boot the mainboard. Trigger apreset from EC console. Trigger reboot from AP console.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/39325/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 6 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Karthik Ramasubramanian (Code Review)

5:13 a.m.

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39325 )

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

Patch Set 6:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39325/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:

https://review.coreboot.org/c/coreboot/+/39325/4/src/mainboard/google/dedede... PS4, Line 131: GPP_C15

...

Just a note: This will have to be exposed in EC ACPI tables eventually.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 6 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Sun, 08 Mar 2020 05:13:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

9 Mar 9 Mar

6:46 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39325 )

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

Patch Set 7: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 7 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 09 Mar 2020 18:46:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9:28 p.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/39325 )

Change subject: mb/google/dedede: Configure EC <-> AP GPIOs ......................................................................

mb/google/dedede: Configure EC <-> AP GPIOs

BUG=b:150869661 TEST=Build and boot the mainboard. Trigger apreset from EC console. Trigger reboot from AP console.

Signed-off-by: Karthikeyan Ramasubramanian kramasub@google.com Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Reviewed-on: https://review.coreboot.org/c/coreboot/+/39325 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/dedede/variants/baseboard/gpio.c M src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h M src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h 3 files changed, 8 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/baseboard/gpio.c b/src/mainboard/google/dedede/variants/baseboard/gpio.c index 31537e0..ce5e20d 100644 --- a/src/mainboard/google/dedede/variants/baseboard/gpio.c +++ b/src/mainboard/google/dedede/variants/baseboard/gpio.c @@ -126,9 +126,9 @@ /* C13 : GPP_C13/UART1_TXD */ PAD_NC(GPP_C13, NONE), /* C14 : EC_IN_RW_OD */ - PAD_NC(GPP_C14, NONE), + PAD_CFG_GPI(GPP_C14, NONE, DEEP), /* C15 : EC_AP_MKBP_INT_L */ - PAD_NC(GPP_C15, NONE), + PAD_CFG_GPI_APIC(GPP_C15, NONE, PLTRST, LEVEL, INVERT), /* C16 : AP_I2C_TRACKPAD_SDA_3V3 */ PAD_CFG_NF(GPP_C16, NONE, DEEP, NF1), /* C17 : AP_I2C_TRACKPAD_SCL_3V3 */ diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h index 2f0024c..0f356f8 100644 --- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h +++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/ec.h @@ -79,4 +79,7 @@ #define SIO_EC_HOST_ENABLE /* EC Host Interface Resources */ #define SIO_EC_ENABLE_PS2K /* Enable PS/2 Keyboard */

+/* Enable EC SYNC IRQ, EC_SYNC_IRQ is defined in baseboard/gpio.h */ +#define EC_ENABLE_SYNC_IRQ + #endif /* __BASEBOARD_EC_H__ */ diff --git a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h index 395143b..de94e76 100644 --- a/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h +++ b/src/mainboard/google/dedede/variants/baseboard/include/baseboard/gpio.h @@ -18,6 +18,9 @@ /* EC wake is LAN_WAKE# which is a special DeepSX wake pin */ #define GPE_EC_WAKE GPE0_LAN_WAK

+/* EC sync irq is GPP_C15_IRQ */ +#define EC_SYNC_IRQ GPP_C15_IRQ + /* Memory configuration board straps */ #define GPIO_MEM_CONFIG_0 GPP_C0 #define GPIO_MEM_CONFIG_1 GPP_C3

-- To view, visit https://review.coreboot.org/c/coreboot/+/39325 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0d6dd0b4264c11f7ee0ef436cc819b0bb92974f7 Gerrit-Change-Number: 39325 Gerrit-PatchSet: 8 Gerrit-Owner: Karthik Ramasubramanian kramasub@google.com Gerrit-Reviewer: Aamir Bohra aamir.bohra@intel.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Justin TerAvest teravest@chromium.org Gerrit-Reviewer: Karthikeyan Ramasubramanian kramasub@chromium.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1721

days inactive

1725

days old

coreboot-gerrit@coreboot.org

13 comments

4 participants

tags (0)

participants (4)

Furquan Shaikh (Code Review)
Justin TerAvest (Code Review)
Karthik Ramasubramanian (Code Review)
Patrick Georgi (Code Review)