Change in coreboot[master]: mb/amd/mandolin/devicetree: disable unused internal ethernet controllers

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Change in ...coreboot[master]:...

Felix Held (Code Review)

24 Jun 2020 24 Jun '20

9:12 p.m.

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42782 )

Change subject: mb/amd/mandolin/devicetree: disable unused internal ethernet controllers ......................................................................

mb/amd/mandolin/devicetree: disable unused internal ethernet controllers

Change-Id: Id4c7ec02f37b35bbc36d40bb937b962cc6413d17 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/42782/1

diff --git a/src/mainboard/amd/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/devicetree.cb index 179582b..d94084c 100644 --- a/src/mainboard/amd/mandolin/devicetree.cb +++ b/src/mainboard/amd/mandolin/devicetree.cb @@ -59,8 +59,8 @@ end device pci 8.2 on # Bridge to Bus B device pci 0.0 on end # AHCI - device pci 0.1 on end # Ethernet - device pci 0.2 on end # Ethernet + device pci 0.1 off end # Ethernet + device pci 0.2 off end # Ethernet end device pci 14.0 on # SM chip drivers/generic/generic # dimm 0-0-0

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Angel Pons (Code Review)

25 Jun 25 Jun

3:30 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42782 )

Change subject: mb/amd/mandolin/devicetree: disable unused internal ethernet controllers ......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/42782/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/42782/1/src/mainboard/amd/mandolin/... PS1, Line 62: Ethernet This device is an Ethernet MAC that relies on an external PHY, right?

-- To view, visit https://review.coreboot.org/c/coreboot/+/42782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4c7ec02f37b35bbc36d40bb937b962cc6413d17 Gerrit-Change-Number: 42782 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 25 Jun 2020 13:30:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

4:04 p.m.

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42782 )

Change subject: mb/amd/mandolin/devicetree: disable unused internal ethernet controllers ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/42782/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/42782/1/src/mainboard/amd/mandolin/... PS1, Line 62: Ethernet

...

This device is an Ethernet MAC that relies on an external PHY, right?

It's an Ethernet MAC and for connecting to things, you typically need some sort of external PHY. To connect to some sort of backplane you might not need a PHY; haven't really looked into that

-- To view, visit https://review.coreboot.org/c/coreboot/+/42782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4c7ec02f37b35bbc36d40bb937b962cc6413d17 Gerrit-Change-Number: 42782 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 25 Jun 2020 14:04:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Gerrit-MessageType: comment

Angel Pons (Code Review)

26 Jun 26 Jun

6:24 p.m.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42782 )

Change subject: mb/amd/mandolin/devicetree: disable unused internal ethernet controllers ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/42782/1/src/mainboard/amd/mandolin/... File src/mainboard/amd/mandolin/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/42782/1/src/mainboard/amd/mandolin/... PS1, Line 62: Ethernet

...

It's an Ethernet MAC and for connecting to things, you typically need some sort of external PHY. […]

Ack

-- To view, visit https://review.coreboot.org/c/coreboot/+/42782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4c7ec02f37b35bbc36d40bb937b962cc6413d17 Gerrit-Change-Number: 42782 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 26 Jun 2020 16:24:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de Gerrit-MessageType: comment

Felix Held (Code Review)

10:46 p.m.

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42782 )

Change subject: mb/amd/mandolin/devicetree: disable unused internal ethernet controllers ......................................................................

mb/amd/mandolin/devicetree: disable unused internal ethernet controllers

Change-Id: Id4c7ec02f37b35bbc36d40bb937b962cc6413d17 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/42782 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/mandolin/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved

diff --git a/src/mainboard/amd/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/devicetree.cb index 0167048..709778d 100644 --- a/src/mainboard/amd/mandolin/devicetree.cb +++ b/src/mainboard/amd/mandolin/devicetree.cb @@ -59,8 +59,8 @@ end device pci 8.2 on # Bridge to Bus B device pci 0.0 on end # AHCI - device pci 0.1 on end # Ethernet - device pci 0.2 on end # Ethernet + device pci 0.1 off end # Ethernet + device pci 0.2 off end # Ethernet end device pci 14.0 on # SM chip drivers/generic/generic # dimm 0-0-0

-- To view, visit https://review.coreboot.org/c/coreboot/+/42782 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id4c7ec02f37b35bbc36d40bb937b962cc6413d17 Gerrit-Change-Number: 42782 Gerrit-PatchSet: 4 Gerrit-Owner: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com Gerrit-Reviewer: Raul Rangel rrangel@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1611

days inactive

1613

days old

coreboot-gerrit@coreboot.org

4 comments

2 participants

tags (0)

participants (2)

Angel Pons (Code Review)
Felix Held (Code Review)