Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42834 )
Change subject: mb/mandolin/devicetree: clarify that Ethernet devices are internal MACs ......................................................................
mb/mandolin/devicetree: clarify that Ethernet devices are internal MACs
Change-Id: Ib7d696f4cc8f5fdcdf45e271b36664d085eb16d5 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/mainboard/amd/mandolin/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/42834/1
diff --git a/src/mainboard/amd/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/devicetree.cb index 709778d..495961f 100644 --- a/src/mainboard/amd/mandolin/devicetree.cb +++ b/src/mainboard/amd/mandolin/devicetree.cb @@ -59,8 +59,8 @@ end device pci 8.2 on # Bridge to Bus B device pci 0.0 on end # AHCI - device pci 0.1 off end # Ethernet - device pci 0.2 off end # Ethernet + device pci 0.1 off end # integrated Ethernet MAC + device pci 0.2 off end # integrated Ethernet MAC end device pci 14.0 on # SM chip drivers/generic/generic # dimm 0-0-0
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42834 )
Change subject: mb/mandolin/devicetree: clarify that Ethernet devices are internal MACs ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42834 )
Change subject: mb/mandolin/devicetree: clarify that Ethernet devices are internal MACs ......................................................................
mb/mandolin/devicetree: clarify that Ethernet devices are internal MACs
Change-Id: Ib7d696f4cc8f5fdcdf45e271b36664d085eb16d5 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/42834 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/amd/mandolin/devicetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/amd/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/devicetree.cb index 709778d..495961f 100644 --- a/src/mainboard/amd/mandolin/devicetree.cb +++ b/src/mainboard/amd/mandolin/devicetree.cb @@ -59,8 +59,8 @@ end device pci 8.2 on # Bridge to Bus B device pci 0.0 on end # AHCI - device pci 0.1 off end # Ethernet - device pci 0.2 off end # Ethernet + device pci 0.1 off end # integrated Ethernet MAC + device pci 0.2 off end # integrated Ethernet MAC end device pci 14.0 on # SM chip drivers/generic/generic # dimm 0-0-0