Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/74824 )
Change subject: mb/google/slippy: Use chromeec_smi_sleep() ......................................................................
mb/google/slippy: Use chromeec_smi_sleep()
Change-Id: I752d5644d6140e5a6d6f53543bbbc5ef7281f3b4 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/mainboard/google/slippy/smihandler.c 1 file changed, 11 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/74824/1
diff --git a/src/mainboard/google/slippy/smihandler.c b/src/mainboard/google/slippy/smihandler.c index efc9486..091d70e 100644 --- a/src/mainboard/google/slippy/smihandler.c +++ b/src/mainboard/google/slippy/smihandler.c @@ -11,7 +11,6 @@ #include <cpu/intel/haswell/haswell.h>
/* Include EC functions */ -#include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/smm.h> #include "ec.h"
@@ -48,25 +47,7 @@ break; }
- switch (slp_typ) { - case ACPI_S3: - /* Enable wake events */ - google_chromeec_set_wake_mask(MAINBOARD_EC_S3_WAKE_EVENTS); - break; - case ACPI_S4: - case ACPI_S5: - /* Enable wake events */ - google_chromeec_set_wake_mask(MAINBOARD_EC_S5_WAKE_EVENTS); - break; - } - - /* Disable SCI and SMI events */ - google_chromeec_set_smi_mask(0); - google_chromeec_set_sci_mask(0); - - /* Clear pending events that may trigger immediate wake */ - while (google_chromeec_get_event() != EC_HOST_EVENT_NONE) - ; + chromeec_smi_sleep(slp_typ, MAINBOARD_EC_S3_WAKE_EVENTS, MAINBOARD_EC_S5_WAKE_EVENTS); }
int mainboard_smi_apmc(u8 apmc)