Attention is currently required from: Mario Scheithauer. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/64024 )
Change subject: drivers/phy/m88e1512: Add new driver for Marvell PHY 88E1512 ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/64024/comment/f82276d3_1899554d PS1, Line 14: One can change parameters in device tree so that the used setup can be Plesae add a blank line above.
https://review.coreboot.org/c/coreboot/+/64024/comment/b4354fc3_4c056a9f PS1, Line 19: https://www.marvell.com/content/dam/marvell/en/public-collateral/ : transceivers/marvell-phys-transceivers-alaska-88e151x-datasheet.pdf Can be in one line.
File src/drivers/phy/m88e1512/chip.h:
https://review.coreboot.org/c/coreboot/+/64024/comment/2fccb879_92d76495 PS1, Line 4: uint8_t device_index; Use native types?
File src/soc/intel/elkhartlake/tsn_gbe.c:
https://review.coreboot.org/c/coreboot/+/64024/comment/cdac6881_7dd713a5 PS1, Line 124: .ops_pci = &pci_dev_ops_pci, Should this be a separate patch, or at least mentioned in the commit message?