Attention is currently required from: Furquan Shaikh, Dtrain Hsu, Henry Sun, Karthik Ramasubramanian.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54057 )
Change subject: mb/google/dedede/var/cret: Enable/disable LTE function based on FW_CONFIG
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Furquan, we need your ACPI shutdown patches ðŸ˜
What about implementing a `_SB.MPTS` and perform the power sequence when entering S5 instead of SMM?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54057
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib926e99aaf9df433a7cff71180ee55431d69f718
Gerrit-Change-Number: 54057
Gerrit-PatchSet: 3
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 13 May 2021 21:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment