Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40947 )
Change subject: nb/intel/sandybridge/raminit: Add comments ......................................................................
nb/intel/sandybridge/raminit: Add comments
Add comments found when testing ECC scrubbing code. This is a cosmetic change.
Change-Id: I7975f6070c2002930eec407a6b101a1295495b25 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/40947/1
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index e80abe7..609204e 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -298,8 +298,14 @@ reg |= (dimmB->width / 8 - 1) << 20; }
- reg |= 1 << 21; /* Rank interleave */ - reg |= 1 << 22; /* Enhanced interleave */ + /* + * Rank interleave: Bit 16 of the physical address space sets + * the rank to use in a dual single rank DIMM configuration. + * That results in every 64KiB being interleaved between two ranks. + */ + reg |= 1 << 21; + /* Enhanced interleave */ + reg |= 1 << 22;
if ((dimmA && (dimmA->ranks > 0)) || (dimmB && (dimmB->ranks > 0))) { ctrl->mad_dimm[channel] = reg;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40947 )
Change subject: nb/intel/sandybridge/raminit: Add comments ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40947 )
Change subject: nb/intel/sandybridge/raminit: Add comments ......................................................................
Patch Set 2: Code-Review+1
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40947 )
Change subject: nb/intel/sandybridge/raminit: Add comments ......................................................................
nb/intel/sandybridge/raminit: Add comments
Add comments found when testing ECC scrubbing code. This is a cosmetic change.
Change-Id: I7975f6070c2002930eec407a6b101a1295495b25 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/40947 Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/northbridge/intel/sandybridge/raminit_common.c 1 file changed, 8 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/sandybridge/raminit_common.c b/src/northbridge/intel/sandybridge/raminit_common.c index 126acbe..3527c8e 100644 --- a/src/northbridge/intel/sandybridge/raminit_common.c +++ b/src/northbridge/intel/sandybridge/raminit_common.c @@ -319,8 +319,14 @@ reg |= (dimmB->width / 8 - 1) << 20; }
- reg |= 1 << 21; /* Rank interleave */ - reg |= 1 << 22; /* Enhanced interleave */ + /* + * Rank interleave: Bit 16 of the physical address space sets + * the rank to use in a dual single rank DIMM configuration. + * That results in every 64KiB being interleaved between two ranks. + */ + reg |= 1 << 21; + /* Enhanced interleave */ + reg |= 1 << 22;
if ((dimmA && (dimmA->ranks > 0)) || (dimmB && (dimmB->ranks > 0))) { ctrl->mad_dimm[channel] = reg;
-
Angel Pons (Code Review) -
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)